Use Airflow version to determine health endpoint #16646

Kyle-Neale · 2024-01-17T21:41:31Z

What does this PR do?

Uses Airflow's stable API to get version and determines which health endpoint needs to be hit for our service check.

Motivation

https://datadoghq.atlassian.net/browse/FRAGENT-2003

Additional Notes

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Changelog entries must be created for modifications to shipped code
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

codecov · 2024-01-17T22:00:34Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a1380e9) 90.33% compared to head (3b71722) 90.54%.
Report is 54 commits behind head on master.

❗ Current head 3b71722 differs from pull request most recent head 6fab204. Consider uploading reports for the commit 6fab204 to get more accurate results

Additional details and impacted files

Flag	Coverage Δ
activemq	`?`
airflow	`90.00% <97.05%> (+0.42%)`	⬆️
cassandra	`?`
hive	`?`
hivemq	`?`
ignite	`?`
jboss_wildfly	`?`
presto	`?`
solr	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

github-actions · 2024-01-17T22:02:11Z

Test Results

8 files 8 suites 7m 12s ⏱️
10 tests 9 ✅ 1 💤 0 ❌
44 runs 36 ✅ 8 💤 0 ❌

Results for commit 6fab204.

♻️ This comment has been updated with latest results.

iliakur

Thanks! A couple things we wanna fix and then we good to go!

airflow/datadog_checks/airflow/airflow.py

airflow/tests/test_unit.py

airflow/datadog_checks/airflow/airflow.py

airflow/tests/test_unit.py

use version to determine health endpoint

97019ec

ghost added the integration/airflow label Jan 17, 2024

Kyle-Neale changed the title ~~use version to determine health endpoint~~ Use Airflow version to determine health endpoint Jan 17, 2024

Kyle-Neale marked this pull request as ready for review January 22, 2024 15:31

Kyle-Neale requested a review from a team as a code owner January 22, 2024 15:31

github-actions bot added the team/agent-integrations label Jan 22, 2024

add changelog

e4989ca

iliakur requested changes Jan 23, 2024

View reviewed changes

airflow/datadog_checks/airflow/airflow.py Outdated Show resolved Hide resolved

airflow/datadog_checks/airflow/airflow.py Outdated Show resolved Hide resolved

airflow/tests/test_unit.py Outdated Show resolved Hide resolved

add get_version functionality to tests and clean up logic

3b71722

Kyle-Neale requested a review from iliakur January 24, 2024 14:55

FlorentClarret reviewed Jan 25, 2024

View reviewed changes

more pythonic

6fab204

iliakur approved these changes Jan 25, 2024

View reviewed changes

Kyle-Neale merged commit fa22660 into master Jan 25, 2024
34 checks passed

Kyle-Neale deleted the kyleneale/remove_inaccurate_warn_message branch January 25, 2024 20:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Airflow version to determine health endpoint #16646

Use Airflow version to determine health endpoint #16646

Kyle-Neale commented Jan 17, 2024 •

edited

Loading

codecov bot commented Jan 17, 2024 •

edited

Loading

github-actions bot commented Jan 17, 2024 •

edited

Loading

iliakur left a comment

Use Airflow version to determine health endpoint #16646

Use Airflow version to determine health endpoint #16646

Conversation

Kyle-Neale commented Jan 17, 2024 • edited Loading

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

codecov bot commented Jan 17, 2024 • edited Loading

Codecov Report

github-actions bot commented Jan 17, 2024 • edited Loading

Test Results

iliakur left a comment

Choose a reason for hiding this comment

Kyle-Neale commented Jan 17, 2024 •

edited

Loading

codecov bot commented Jan 17, 2024 •

edited

Loading

github-actions bot commented Jan 17, 2024 •

edited

Loading