Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the configuration file to include the new oauth options parameter #16835

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Update the configuration file to include the new oauth options parameter #16835

merged 1 commit into from
Feb 9, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Feb 9, 2024 •
edited
Loading

What does this PR do?

Update the configuration file to include the new oauth options parameter

Motivation

This option has been added in #16812

Additional Notes

https://datadoghq.atlassian.net/browse/AI-3752

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret FlorentClarret requested review from a team as code owners February 9, 2024 08:09
@FlorentClarret FlorentClarret added this to the 7.52.0 milestone Feb 9, 2024
vivek-datadog
vivek-datadog approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@vivek-datadog vivek-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

iliakur
iliakur approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The many nested indentations in the docs look a bit odd, but they make sense.

davidor
davidor approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@davidor davidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for container-integrations files

aliciascott
aliciascott approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@FlorentClarret FlorentClarret merged commit 0f4e6de into master Feb 9, 2024
46 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/ddev/oauth_option branch February 9, 2024 16:30
Kyle-Neale pushed a commit that referenced this pull request Feb 12, 2024
@FlorentClarret @Kyle-Neale
Update the configuration file to include the new oauth options parame…
fc9737e 
…ter (#16835)
NouemanKHAL pushed a commit that referenced this pull request Mar 4, 2024
@FlorentClarret @NouemanKHAL
Update the configuration file to include the new oauth options parame…
0c72ed3 
…ter (#16835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliakur iliakur iliakur approved these changes

@davidor davidor davidor approved these changes

@aliciascott aliciascott aliciascott approved these changes

@Kyle-Neale Kyle-Neale Kyle-Neale approved these changes

@jose-manuel-almaza jose-manuel-almaza jose-manuel-almaza approved these changes

@vivek-datadog vivek-datadog vivek-datadog approved these changes

Assignees
No one assigned
Labels
team/agent-integrations team/container-integrations team/documentation team/platform-integrations
Projects
None yet
Milestone
7.52.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@FlorentClarret @iliakur @davidor @aliciascott @Kyle-Neale @jose-manuel-almaza @vivek-datadog