-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ongoing duration metric to Airflow integration #16847
Conversation
Test Results 4 files 4 suites 4m 6s ⏱️ Results for commit 0a713fc. ♻️ This comment has been updated with latest results. |
bca476d
to
7c9a2e2
Compare
…ation for auth_backend(s) config
7c9a2e2
to
22e0bbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some formatting and punctuation suggestions for consistency, but otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add ongoing duration metric to Airflow * add parsing iso string support for PY2 * add auth protocol for other E2E environment and time convert method * remove PY2 references from parse iso method and add links to documentation for auth_backend(s) config * remove unnecessary six import * removed airflow.cfg since it breaks 2.1 tests * add changelog * fixes and updates to test readme * add OOTB monitors and fix test readme * move monitor descriptions to right level and add monitors to manifest * fix monitor json added to manifest eb6fac3
* add ongoing duration metric to Airflow * add parsing iso string support for PY2 * add auth protocol for other E2E environment and time convert method * remove PY2 references from parse iso method and add links to documentation for auth_backend(s) config * remove unnecessary six import * removed airflow.cfg since it breaks 2.1 tests * add changelog * fixes and updates to test readme * add OOTB monitors and fix test readme * move monitor descriptions to right level and add monitors to manifest * fix monitor json added to manifest
What does this PR do?
Motivation
https://datadoghq.atlassian.net/browse/AI-3755
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.