Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ongoing duration metric to Airflow integration #16847

Merged
merged 11 commits into from
Feb 15, 2024

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Feb 10, 2024

What does this PR do?

Motivation

https://datadoghq.atlassian.net/browse/AI-3755

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

github-actions bot commented Feb 10, 2024

Test Results

 4 files   4 suites   4m 6s ⏱️
12 tests 11 ✅ 1 💤 0 ❌
26 runs  22 ✅ 4 💤 0 ❌

Results for commit 0a713fc.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fd710dc) 90.56% compared to head (0a713fc) 90.67%.
Report is 24 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
airflow 92.20% <96.61%> (+2.32%) ⬆️
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kyle-Neale Kyle-Neale force-pushed the kyleneale/add_task_current_duration branch from bca476d to 7c9a2e2 Compare February 12, 2024 18:34
@Kyle-Neale Kyle-Neale force-pushed the kyleneale/add_task_current_duration branch from 7c9a2e2 to 22e0bbc Compare February 12, 2024 18:46
@Kyle-Neale Kyle-Neale marked this pull request as ready for review February 13, 2024 01:59
@Kyle-Neale Kyle-Neale requested a review from a team as a code owner February 13, 2024 01:59
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some formatting and punctuation suggestions for consistency, but otherwise looks good.

airflow/tests/README.md Outdated Show resolved Hide resolved
airflow/tests/README.md Outdated Show resolved Hide resolved
airflow/tests/README.md Outdated Show resolved Hide resolved
airflow/tests/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kyle-Neale Kyle-Neale merged commit eb6fac3 into master Feb 15, 2024
40 checks passed
@Kyle-Neale Kyle-Neale deleted the kyleneale/add_task_current_duration branch February 15, 2024 18:32
github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
* add ongoing duration metric to Airflow

* add parsing iso string support for PY2

* add auth protocol for other E2E environment and time convert method

* remove PY2 references from parse iso method and add links to documentation for auth_backend(s) config

* remove unnecessary six import

* removed airflow.cfg since it breaks 2.1 tests

* add changelog

* fixes and updates to test readme

* add OOTB monitors and fix test readme

* move monitor descriptions to right level and add monitors to manifest

* fix monitor json added to manifest eb6fac3
NouemanKHAL pushed a commit that referenced this pull request Mar 4, 2024
* add ongoing duration metric to Airflow

* add parsing iso string support for PY2

* add auth protocol for other E2E environment and time convert method

* remove PY2 references from parse iso method and add links to documentation for auth_backend(s) config

* remove unnecessary six import

* removed airflow.cfg since it breaks 2.1 tests

* add changelog

* fixes and updates to test readme

* add OOTB monitors and fix test readme

* move monitor descriptions to right level and add monitors to manifest

* fix monitor json added to manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants