update custom_queries configuration to support optional collection_interval #16957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
The |
|
The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Test Results 105 files 105 suites 1h 21m 15s ⏱️ Results for commit 5492f35. ♻️ This comment has been updated with latest results. |
hestonhoffman
previously approved these changes
Feb 23, 2024
Kyle-Neale
previously approved these changes
Feb 23, 2024
jmeunier28
reviewed
Feb 23, 2024
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/db.yaml
Outdated
Show resolved
Hide resolved
jmeunier28
reviewed
Feb 23, 2024
lu-zhengda
dismissed stale reviews from Kyle-Neale and hestonhoffman
via
e0a117c
nenadnoveljic
previously approved these changes
Feb 26, 2024
FlorentClarret
approved these changes
Feb 26, 2024
FlorentClarret
pushed a commit
that referenced
this pull request
Mar 1, 2024
…terval (#16957) * update custom_queries configuration to support optional collection_interval * add changelog * update config * sync config * sync models * update collection_interval description * remove duplicate changelog
NouemanKHAL
pushed a commit
that referenced
this pull request
Mar 4, 2024
…terval (#16957) * update custom_queries configuration to support optional collection_interval * add changelog * update config * sync config * sync models * update collection_interval description * remove duplicate changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR #16765 introduced support of customizable
collection_intervalfor custom queries. This PR adds an optional config optioncollection_intervalto thecustom_queriesconfiguration template.Motivation
custom_queriesnow supports optionalcollection_interval. This option can be useful to have a custom query that does not need to be executed on every check run.Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.