Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the metric_prefix option for custom queries #17061

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Mar 5, 2024

What does this PR do?

Document the metric_prefix option for custom queries

Motivation

Added in #16958

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (6e3a113) to head (8a6c801).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
clickhouse 95.65% <ø> (?)
confluent_platform ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
snowflake 96.27% <ø> (ø)
solr ?
vertica 98.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Mar 5, 2024

Test Results

 38 files   38 suites   10m 7s ⏱️
111 tests 109 ✅  2 💤 0 ❌
531 runs  467 ✅ 64 💤 0 ❌

Results for commit 8a6c801.

Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

til that mongo already documents this!

@FlorentClarret FlorentClarret merged commit 30e2b3f into master Mar 5, 2024
68 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/metric_prefix branch March 5, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants