Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the configuration to include the metric_prefix option #17065

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Mar 6, 2024

What does this PR do?

Update the configuration to include the metric_prefix option

Motivation

Added in the base check in #16958

Additional Notes

Noticed we forgot it working on a support case

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

github-actions bot commented Mar 6, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.97%. Comparing base (5132145) to head (165bcbf).
Report is 9 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
clickhouse 95.65% <ø> (?)
confluent_platform ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
mysql 87.58% <ø> (?)
oracle 88.54% <ø> (?)
presto ?
sap_hana 91.37% <ø> (?)
singlestore 90.81% <ø> (ø)
snowflake 96.27% <ø> (ø)
solr ?
sqlserver 90.00% <ø> (?)
teradata 94.05% <ø> (ø)
vertica 98.34% <ø> (ø)
voltdb 97.27% <ø> (+0.41%) ⬆️
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Mar 6, 2024

Test Results

  105 files    105 suites   1h 21m 58s ⏱️
  656 tests   641 ✅  15 💤 0 ❌
4 951 runs  4 618 ✅ 333 💤 0 ❌

Results for commit 165bcbf.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for docs

@FlorentClarret FlorentClarret merged commit 6374198 into master Mar 7, 2024
54 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/metric_prefix branch March 7, 2024 07:41
marlon-merida pushed a commit that referenced this pull request Mar 11, 2024
* Update the configuration to include the `metric_prefix` option

* Update the configuration to include the `metric_prefix` option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants