-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hazelcast integration - Add queues, topics and reltopics and name tag. #17367
base: master
Are you sure you want to change the base?
Conversation
…ics, reltopic and queue metrics. The hazelcast integration is not showing important details such as the map name that's being monitored. It would be great to include that, as well as include metrics for other things such as queues and topics.
Test Results2 files 2 suites 43s ⏱️ For more details on these failures, see this check. Results for commit d2002e1. ♻️ This comment has been updated with latest results. |
The changelog type |
The changelog type |
The changelog type |
The changelog type |
The changelog type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, approving with some minor updates requested for consistency in the metric descriptions
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
The changelog type |
…and reltopics to test out of the box.
The changelog type |
The changelog type |
The changelog type |
The changelog type |
The changelog type |
The changelog type |
There appeared to be some confusion in the past (myself included) on the hazelcast mc health checks - this reports the status of hazelcast's management center, not the status of the cluster managed by management center, since there are multiple clusters which can be managed by mancenter, this makes sense in a way. Therefore, the status of frozen, no migration, etc aren't ever going to show for this check. This check simply checks mancenter's heath probe endpoint to confirm if it is up / working. I don't think mancenter is opensource, so I can't see the possible statuses here, but I suspect this is hardcoded and just used for readiness / liveness probes. I was able to dig up the old docs - the cluster state got conflated - https://docs.hazelcast.org/docs/management-center/latest/manual/html/index.html#cluster-state however if you read this section https://web.archive.org/web/20200511115951/https://docs.hazelcast.org/docs/management-center/latest/manual/html/index.html#enabling-health-check-endpoint it's clear this is just and endpoint for health checks. |
Revisiting this PR. Will follow up when I get tests passing 🙏 |
What does this PR do?
Motivation
The Hazelcast integration is not showing important details such as the map name that's being monitored. It would be great to include that, as well as include metrics for other things such as queues and topics so that we can get finer grained visibility to the maps, queues and topics that we are most interested in as a Datadog customer using Hazelcast.
Additional Notes
This is my first PR to DD, sorry if I did not follow guidelines.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged