Fix error message when TCP check fails #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appveyor fail unrelated to your changes, re-running the build |
masci
suggested changes
Jun 15, 2018
| @@ -53,7 +53,8 @@ def _load_conf(self, instance): | |||
| addr = socket.gethostbyname(url) | |||
| socket_type = socket.AF_INET | |||
| except Exception: | |||
| raise BadConfException("URL: %s is not a correct IPv4, IPv6 or hostname" % addr) | |||
| msg = "URL: %s is not a correct IPv4, IPv6 or hostname" % url | |||
There was a problem hiding this comment.
nit: can you use the string format method instead of %?
There was a problem hiding this comment.
Done.
I prefer .format() but the line and the rest of the file was already %, also with format it is over 79 characters. Let me know if you want me to split it up into multiple lines.
There was a problem hiding this comment.
Yup, we're trying to gradually consolidate the use of a more modern style across the codebase and I took the opportunity 😄
Line width is fine if under 120 chars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Shows an error message instead of a traceback.
Motivation
I was getting a traceback because
addrwas not defined.Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?