Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the Cisco Check more resilient #1785

Merged
merged 3 commits into from
Jun 21, 2018
Merged

Makes the Cisco Check more resilient #1785

merged 3 commits into from
Jun 21, 2018

Conversation

gmmeyer
Copy link
Contributor

@gmmeyer gmmeyer commented Jun 21, 2018

What does this PR do?

The Cisco Check should try to collect everything, even if some types of failures occur that shouldn't stop it from running.

Network errors and access errors should be ignored, because that could mean that a switch has been cycled out or something. Also sometimes switches can be a part of the APIC without actually being monitored or managed by the apic, and it will fail on some of the collection requests.

Motivation

Found some failures, it shouldn't stop halfway.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

We might want to add service checks to some of these requests. I am not sure which ones, I'm gonna add them in a followup PR.

@gmmeyer gmmeyer merged commit a38da8f into master Jun 21, 2018
@gmmeyer gmmeyer deleted the greg/cisco-fixes branch June 21, 2018 20:46
@gmmeyer gmmeyer added this to the 6.3.1 milestone Jun 21, 2018
@masci masci removed this from the Next milestone Jun 26, 2018
@gmmeyer gmmeyer added this to the 6.3.2 milestone Jun 29, 2018
nmuesch pushed a commit that referenced this pull request Jul 2, 2018
* Adds some better error handling to the cisco check so it will not fail as badly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants