Makes the Cisco Check more resilient #1785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Cisco Check should try to collect everything, even if some types of failures occur that shouldn't stop it from running.
Network errors and access errors should be ignored, because that could mean that a switch has been cycled out or something. Also sometimes switches can be a part of the APIC without actually being monitored or managed by the apic, and it will fail on some of the collection requests.
Motivation
Found some failures, it shouldn't stop halfway.
Review checklist
no-changelog
label attachedAdditional Notes
We might want to add service checks to some of these requests. I am not sure which ones, I'm gonna add them in a followup PR.