Improve messages around dependency spec management #17969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Validation says which commands can fix the failure. 2. Freeze/sync have docs that make it clear what they do and how they differ. 3. Freeze says what it's doing to the "static file"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
HadhemiDD
approved these changes
Jul 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
* Improve messages around dependency spec management 1. Validation says which commands can fix the failure. 2. Freeze/sync have docs that make it clear what they do and how they differ. 3. Freeze says what it's doing to the "static file" * add changelog * adjust test 3b646f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
I can never remember what the difference between
ddev dep freezeandddev dep syncis. Or which one to use to achieve my goal.I also find the
ddev validate deperror frustrating because it doesn't say how we can fix the failure. Suggesting fixes is something other validations are doing for a while now.Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged