fixes cisco for username and password #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2267 +/- ##
==========================================
+ Coverage 79.77% 95.08% +15.3%
==========================================
Files 170 17 -153
Lines 7838 5171 -2667
Branches 1159 195 -964
==========================================
- Hits 6253 4917 -1336
+ Misses 1275 183 -1092
+ Partials 310 71 -239 |
zippolyte
reviewed
Sep 19, 2018
| cookie = ('APIC-Request-Signature={}; ' | ||
| 'APIC-Certificate-Algorithm=v1.0; ' | ||
| 'APIC-Certificate-Fingerprint=fingerprint; ' | ||
| 'APIC-Certificate-DN={}').format(signature, self.certDn) | ||
| prepped_request.headers['Cookie'] = cookie | ||
| else: | ||
| self.log.warning("The Cisco ACI Integration requires either a cert or a username and password") |
There was a problem hiding this comment.
Shouldn't this be an error instead ? Can we even continue the check if we have neither ?
There was a problem hiding this comment.
it will just error out anyway
zippolyte
previously approved these changes
Sep 25, 2018
zippolyte
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Cisco ACI Integration had a regression in username and password when we added certificates
Motivation
issue #2237 from @jgcasd
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?