[jmx] add rmi registry ssl config option #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmuesch
reviewed
Oct 10, 2018
There was a problem hiding this comment.
This looks good to me overall. Were you able to test out this feature with one of these integrations? (Asking since we don't have integration tests for the JMX checks)
Looks like two of these integrations conf.yaml files were moved to the new format, for readability. Can you adjust those as well?
I also think we should make this a changelog/added label as it means the conf yaml file being shipped is going to contain new params
arbll
force-pushed
the
arbll/rmi-ssl-jmxfetch
branch
from
070d7eb
to
c1722df
Compare
|
Thanks for the feedback @nmuesch! The new features are linked to the target JVM configuration and were tested against a simple Java app. I fixed the two conflicts and moved them to the new format. |
nmuesch
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a few new SSL related config option introduced in DataDog/jmxfetch#185
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?