Support Python 3 #2417
Merged
Support Python 3 #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
force-pushed
the
ofek/es
branch
2 times, most recently
from
074b603
to
ed6771a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2417 +/- ##
==========================================
+ Coverage 83.91% 89.83% +5.91%
==========================================
Files 580 11 -569
Lines 34339 590 -33749
Branches 4175 80 -4095
==========================================
- Hits 28817 530 -28287
+ Misses 4270 41 -4229
+ Partials 1252 19 -1233 |
ofek
force-pushed
the
ofek/es
branch
2 times, most recently
from
2f27293
to
2bd4478
Compare
masci
suggested changes
Oct 18, 2018
| @@ -15,47 +16,47 @@ def test_stats_for_version(): | |||
|
|
|||
| # v0.90.5 | |||
| metrics = stats_for_version([0, 90, 5]) | |||
| assert len(metrics) == 127 | |||
| assert len(metrics) == 124 | |||
There was a problem hiding this comment.
The version detection functions were forever modifying the constants and now we make proper copies,
masci
previously approved these changes
Oct 18, 2018
zippolyte
approved these changes
Oct 18, 2018
ofek
added a commit
that referenced
this pull request
Oct 19, 2018
* Support Python 3 * add comment * remove whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Also