Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python3 Support #2583

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Add Python3 Support #2583

merged 1 commit into from
Nov 14, 2018

Conversation

nmuesch
Copy link
Contributor

@nmuesch nmuesch commented Nov 14, 2018

What does this PR do?

Add support for Python3

Motivation

Be compat with py27 and py36

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@codecov-io
Copy link

Codecov Report

Merging #2583 into master will decrease coverage by 1.31%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master   #2583      +/-   ##
=========================================
- Coverage   83.92%   82.6%   -1.32%     
=========================================
  Files         644       6     -638     
  Lines       36394     184   -36210     
  Branches     4420      25    -4395     
=========================================
- Hits        30544     152   -30392     
+ Misses       4540      18    -4522     
+ Partials     1310      14    -1296

@masci masci merged commit 11fe8a3 into master Nov 14, 2018
@masci masci deleted the nick/activemq_xml3 branch November 14, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants