Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #2834

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Support Python 3 #2834

merged 1 commit into from
Dec 26, 2018

Conversation

gmmeyer
Copy link
Contributor

@gmmeyer gmmeyer commented Dec 26, 2018

What does this PR do?

This makes Lighthttpd support Python 3.

The changes are largely small string handling issues, nothing major.

Motivation

馃悕 3锔忊儯 馃殏

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@codecov-io
Copy link

Codecov Report

Merging #2834 into master will decrease coverage by 3.53%.
The diff coverage is 80%.

@@            Coverage Diff            @@
##           master   #2834      +/-   ##
=========================================
- Coverage   84.73%   81.2%   -3.54%     
=========================================
  Files         662       4     -658     
  Lines       37615     133   -37482     
  Branches     4508      17    -4491     
=========================================
- Hits        31873     108   -31765     
+ Misses       4427      15    -4412     
+ Partials     1315      10    -1305

@gmmeyer gmmeyer merged commit a2ccc91 into master Dec 26, 2018
@gmmeyer gmmeyer deleted the greg/lighthttpd3 branch December 26, 2018 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants