Support Python 3 #3029
Merged
Support Python 3 #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3029 +/- ##
===========================================
+ Coverage 84.15% 95.13% +10.98%
===========================================
Files 673 19 -654
Lines 36595 5205 -31390
Branches 4336 197 -4139
===========================================
- Hits 30798 4952 -25846
+ Misses 4548 181 -4367
+ Partials 1249 72 -1177 |
ofek
requested changes
Jan 25, 2019
cisco_aci/tox.ini
Outdated
| -e../datadog_checks_base[deps] | ||
| -rrequirements-dev.txt | ||
| unit: -e../datadog_checks_base[deps] | ||
| unit: -rrequirements-dev.txt |
There was a problem hiding this comment.
We need these no matter what so let's remove the specifiers
cisco_aci/tox.ini
Outdated
| commands = | ||
| pip install -r requirements.in | ||
| pytest -v | ||
| unit: pip install -r requirements.in |
nmuesch
requested changes
Jan 25, 2019
| import aci_metrics | ||
| from six import iteritems | ||
|
|
||
| from . import aci_metrics | ||
| from . import helpers | ||
| from . import exceptions |
There was a problem hiding this comment.
Nit: could these be imported from the same line?
| import aci_metrics | ||
| from six import iteritems | ||
|
|
||
| from . import aci_metrics | ||
| from . import helpers |
There was a problem hiding this comment.
Could these be one line too?
cisco_aci/tests/conftest.py
Outdated
| 'DataDog', | ||
| ], | ||
| "tags": ["project:cisco_aci"], | ||
| } | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def aggregator(): |
There was a problem hiding this comment.
We can remove this too as its a global fixture now.
nmuesch
approved these changes
Jan 25, 2019
ofek
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need to support python 3 in all things. This check was a rough one and I definitely need someone to look it over pretty thoroughly to ensure I did everything right.
Motivation
馃悕 3锔忊儯 馃殏
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?