Add logs section #3097
Merged
Add logs section #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phrawzty
suggested changes
Feb 11, 2019
| ## | ||
| ## type - mandatory - Type of log input source (tcp / udp / file / windows_event) | ||
| ## port / path / channel - mandatory - Set port if type is tcp or udp. Set path if type is file and channel if windows_event | ||
| ## service - mandatory - Name of the service owning the log |
There was a problem hiding this comment.
Suggested change
| ## service - mandatory - Name of the service owning the log | |
| ## service - mandatory - Name of the service that owns the log |
Is that accurate? Or is it the name of the service that generates the logs, for example?
There was a problem hiding this comment.
it's the name of the service that generates the logs not own it, since we want to bind those logs to the corresponding APM service.
There was a problem hiding this comment.
Ok, got it. Let's be clear about that.
Suggested change
| ## service - mandatory - Name of the service owning the log | |
| ## service - mandatory - Name of the service that generated the log |
phrawzty
suggested changes
Feb 13, 2019
| ## | ||
| ## type - mandatory - Type of log input source (tcp / udp / file / windows_event) | ||
| ## port / path / channel - mandatory - Set port if type is tcp or udp. Set path if type is file and channel if windows_event | ||
| ## service - mandatory - Name of the service owning the log |
There was a problem hiding this comment.
Ok, got it. Let's be clear about that.
Suggested change
| ## service - mandatory - Name of the service owning the log | |
| ## service - mandatory - Name of the service that generated the log |
|
Thanks for the suggestions/review. I think I've addressed everything @phrawzty Could you take another look? |
phrawzty
approved these changes
Feb 14, 2019
zippolyte
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds logs section to readme and example yaml file.
Adds the log collection category to the manifest file
Most of this info came from here - http://www.postfix.org/BASIC_CONFIGURATION_README.html#syslog_howto
Motivation
We now have an OOTB logs pipeline for postfix so update the docs and yaml to reflect that.
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?