Adds Presto Integration

[fanny-jiang]

What does this PR do?

Adds Presto JMX-based integration

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

• PR title must be written as a CHANGELOG entry (see why)
• Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
• PR must have changelog/ and integration/ labels attached
• Feature or bugfix must have tests
• Git history must be clean
• If PR adds a configuration option, it must be added to the configuration file.

[codecov]

Codecov Report

Merging #3131 into master will decrease coverage by 7.96%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master    #3131      +/-   ##
==========================================
- Coverage   84.44%   76.47%   -7.97%     
==========================================
  Files         680        4     -676     
  Lines       36099       17   -36082     
  Branches     4195        0    -4195     
==========================================
- Hits        30482       13   -30469     
+ Misses       4382        4    -4378     
+ Partials     1235        0    -1235

[gzussa]

This is great!!
When running the environment. I am getting this error

ddev env check presto py27-latest 
=========
Collector
=========

  Running Checks
  ==============

    presto
    ------
      Instance ID: presto_380af9d053759530 [ERROR]
      Total Runs: 1
      Metric Samples: Last Run: 0, Total: 0
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s
      Error: exec: "java": executable file not found in $PATH
      No traceback

Check has run only once, if some metrics are missing you can try again with --check-rate to see any other metric if available.
Note: If some metrics are missing, you may want to try again with the -r / --rate flag.

However, java is in my PATH. Do you know what I am missing?
I didn't check the metadata file in details. However, if there are metrics you are unsure about feel free to ask about them.

[fanny-jiang]

Hey @gzussa! Since java and jmxfetch isn't packaged with the standard agent images, you'll need to start the docker environment using the -jmx tag of agent image. And ddev env check doesn't seem to work with jmx checks, it just hangs. @ofek, @nmuesch, and I were noticing that while testing a few weeks ago. Not exactly sure where the limitation is in the code.

Try ddev env start presto py27-latest -a datadog/agent:latest-jmx

That should start the presto docker environment with the jmx agent. Although we'll may need to fix ddev check to work with jmx checks in order to fully be able to run jmx checks against the docker environment. However, running the agent status command also works fine with checking the status of the presto check:

docker exec -it dd_presto_py27-latest agent status

[...]

========
JMXFetch
========

  Initialized checks
  ==================
    presto
      instance_name : presto-localhost-9999
      message :
      metric_count : 49
      service_check_count : 0
      status : OK
  Failed checks
  =============
    no checks

[...]

[gzussa]

Maybe, let's add a comment next to the dd_environment method with those details so everyone know about it.

[nmuesch]

LGTM!

[ruthnaebeck]

👍 for docs

[gzussa]

Great work!