Add tags option to hyperv #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
approved these changes
Mar 20, 2019
zippolyte
requested changes
Mar 20, 2019
| @@ -1,4 +1,12 @@ | |||
| init_config: | |||
|
|
|||
| instances: | |||
| - {} | |||
There was a problem hiding this comment.
Not sure we want to get rid of the {}
There was a problem hiding this comment.
I thought the same but config validation passes 🤷♂️
There was a problem hiding this comment.
and does it work with an agent ?
There was a problem hiding this comment.
@ofek was able to test this locally with success 🎉
zippolyte
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
HyperV is a sub class of PDHBaseCheck so its supposed to support things like
tagsOOTB! -integrations-core/datadog_checks_base/datadog_checks/base/checks/win/winpdh_base.py
Line 46 in 9893584
Motivation
Keep the yaml file up to date.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached