Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example tags section #3431

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Fix example tags section #3431

merged 3 commits into from
Apr 15, 2019

Conversation

jgibbons-cp
Copy link
Contributor

What does this PR do?

Fixes and exception

A brief description of the change being made with this pull request.

Changes:

tags:

- environment: default_environment

- datacenter: default_datacenter

to:

tags:

environment: default_environment

datacenter: default_datacenter

As the yaml was causing exceptions.

Motivation

What inspired you to submit this pull request?

So others didn't run into the same issue as it took quite a while to debug.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@jgibbons-cp jgibbons-cp requested a review from a team as a code owner March 29, 2019 23:14
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgibbons-cp Nice find! Though actually the issue is the space after the colon. Let's change that instead.

@ofek ofek changed the title removed "- " from the tags: section as it was causing an exception Fix example tags section Apr 15, 2019
@ofek ofek merged commit d1b02f2 into master Apr 15, 2019
@ofek ofek deleted the tags_yaml_fix branch April 15, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants