Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hive integration #3723

Merged
merged 29 commits into from
May 29, 2019
Merged

Hive integration #3723

merged 29 commits into from
May 29, 2019

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented May 7, 2019

What does this PR do?

Add a Hive as a new integration.

Motivation

Additional Notes

This integration checks 2 parts of Hive (with 2 different JMX connection): Hive MetaStore and HiveServer2.

The dashboard will be added in a future PR.
The logs will be added in a future PR.

Metrics list validated.

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #3723 into master will decrease coverage by 7.62%.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##           master    #3723      +/-   ##
==========================================
- Coverage   86.57%   78.94%   -7.63%     
==========================================
  Files         730        5     -725     
  Lines       38008       19   -37989     
  Branches     4547        0    -4547     
==========================================
- Hits        32905       15   -32890     
+ Misses       3866        4    -3862     
+ Partials     1237        0    -1237

Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really minor nits, looks good.

hive/metadata.csv Outdated Show resolved Hide resolved
hive/datadog_checks/hive/data/conf.yaml.example Outdated Show resolved Hide resolved
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small documentation nits

hive/README.md Outdated Show resolved Hide resolved
hive/README.md Outdated Show resolved Hide resolved
@coignetp coignetp requested a review from a team as a code owner May 27, 2019 07:57
therve
therve previously approved these changes May 28, 2019
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

hive/manifest.json Outdated Show resolved Hide resolved
hive/assets/service_checks.json Outdated Show resolved Hide resolved
hive/README.md Outdated Show resolved Hide resolved
hive/README.md Outdated Show resolved Hide resolved
ofek
ofek previously approved these changes May 28, 2019
hive/README.md Outdated Show resolved Hide resolved
hive/README.md Outdated Show resolved Hide resolved
hive/README.md Outdated Show resolved Hide resolved
hive/README.md Outdated Show resolved Hide resolved
hive/README.md Outdated Show resolved Hide resolved
hive/README.md Outdated Show resolved Hide resolved
hive/README.md Outdated Show resolved Hide resolved
hive/README.md Outdated Show resolved Hide resolved
Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@coignetp coignetp merged commit ea10d96 into master May 29, 2019
@coignetp coignetp deleted the paul/hive branch May 29, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants