Sanitize external host tags #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
reviewed
May 21, 2019
| @@ -152,7 +152,7 @@ def check(self, instance): | |||
| self.service_check(SERVICE_CHECK_NAME, AgentCheck.OK, tags=service_check_tags) | |||
|
|
|||
| if set_external_tags: | |||
| set_external_tags(self.get_external_host_tags()) | |||
| self.set_external_tags(self.get_external_host_tags()) | |||
There was a problem hiding this comment.
Should we remove the import for set_external_tags at the top ?
There was a problem hiding this comment.
No b/c we need a way to tell if on A5
There was a problem hiding this comment.
let's do
if hasattr(self, "set_external_tags"):then, and remove the import at the top
There was a problem hiding this comment.
Or just remove completely that if. We have pinned integrations in A5
therve
previously approved these changes
May 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #3792 +/- ##
=========================================
+ Coverage 86.74% 88.9% +2.15%
=========================================
Files 730 38 -692
Lines 37649 8112 -29537
Branches 4467 520 -3947
=========================================
- Hits 32660 7212 -25448
+ Misses 3799 755 -3044
+ Partials 1190 145 -1045 |
zippolyte
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Handle bytes or unicode