Improve API logs #3794

AlexandreYang · 2019-05-22T09:21:32Z

[cisco_aci] improve logs on failed call to Cisco ACI api.

The response content include useful information from Cisco ACI.

Currently we only get: 400 Client Error: Bad Request for url.

The response content contains info like: the messaging layer was unable to deliver the stimulus (destination (node) is marked unavailable)

PR title must be written as a CHANGELOG entry (see why)
Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
PR must have changelog/ and integration/ labels attached
Feature or bugfix must have tests
Git history must be clean
If PR adds a configuration option, it must be added to the configuration file.

cisco_aci/datadog_checks/cisco_aci/api.py

[cisco_aci] improve api logs

047a803

AlexandreYang requested a review from a team as a code owner May 22, 2019 09:21

coignetp reviewed May 22, 2019

View reviewed changes

cisco_aci/datadog_checks/cisco_aci/api.py Outdated Show resolved Hide resolved

[cisco_aci] merge logs in api.py

360755e

AlexandreYang force-pushed the AlexandreYang/cisco_aci/improve-api-logs branch from a8eb8b8 to 360755e Compare May 22, 2019 12:22

hithwen approved these changes May 22, 2019

View reviewed changes

ofek changed the title ~~[cisco_aci] improve api logs~~ Improve API logs May 23, 2019

ofek added changelog/Added integration/cisco_aci labels May 23, 2019

ofek approved these changes May 23, 2019

View reviewed changes

ofek merged commit 073b120 into master May 23, 2019

ofek deleted the AlexandreYang/cisco_aci/improve-api-logs branch May 23, 2019 14:55

Provide feedback