[Feature] Istio Mixer and Mesh endpoints are optional #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 5, 2019 13:22
Incremented version to 2.4.0 and made all configs optional with at least 1 required for integration to succeed.
Updated documentation to reflect changes to the integration.
Configured tests for Pilot only and Galley only instances.
added 6 commits
June 5, 2019 19:41
Another typo. Fixed.
Added proper iterator for pilot and galley metrics
Increased Agent Requirement version to 2.4.0 from 2.3.0.
Fixed Flake8 style errors
Fixed one missing style change in tests and one in conf.yaml.example
Reformatted some mocks as per recommendations.
therve
requested changes
Jun 6, 2019
added 2 commits
June 6, 2019 09:56
Rephrased some comments and removed release related version changes.
Changed one more comment for clarity.
Codecov Report
@@ Coverage Diff @@
## master #3875 +/- ##
==========================================
+ Coverage 86.85% 92.93% +6.08%
==========================================
Files 737 4 -733
Lines 37971 184 -37787
Branches 4418 24 -4394
==========================================
- Hits 32979 171 -32808
+ Misses 3832 6 -3826
+ Partials 1160 7 -1153 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3875 +/- ##
==========================================
+ Coverage 86.85% 92.93% +6.08%
==========================================
Files 737 4 -733
Lines 37971 184 -37787
Branches 4418 24 -4394
==========================================
- Hits 32979 171 -32808
+ Misses 3832 6 -3826
+ Partials 1160 7 -1153 |
therve
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables the istio integration to be configured with any combination of endpoints, instead of requiring Mesh and Mixer.
Motivation
This PR is a solution for an open issue I have with DD support (internal #227716). This stems from an issue with the integration regarding multiple instances of pilot. If using the flat config file to create the checks in the agent, the kubernetes service is used to access endpoints of the istio components. This is fine if you have one instance of telemetry, galley, and pilot. We have multiple pilot instances, and at any time the kubernetes service only routes to one of them. This is not helpful if we want to sum all metrics across pilot instances. The solution to this problem is A) this PR, and B) use autodiscovery annotations on the pilot (or other istio component) pod to have datadog gather metrics from each discrete instance.
Additional Notes
I admit my pytest experience is not great, so the tests of Pilot only and Galley only instances are just copies of existing tests with some changes.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached