Support citadel endpoint #3962
Merged
Support citadel endpoint #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
We still have comments saying that because of backward compatibility we support not specifying the endpoint for galley and pilot. This is not the case anymore, removing them would be nice
https://github.com/DataDog/integrations-core/pull/3962/files#diff-0654f0b39e01e79e8678617e2d69bdf2L287
Besides, I really like how generic it is to add a new istio endpoint, this is very readable.
therve
force-pushed
the
therve/istio-citadel
branch
from
27b5cac
to
39d37e8
Compare
FlorianVeaux
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds supports for monitoring the citadel endpoint.