Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event submission call #4044

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Fix event submission call #4044

merged 2 commits into from
Jul 5, 2019

Conversation

FlorianVeaux
Copy link
Contributor

Some issues that appeared from testing the cisco integration.
Also adds a note that some capacity metric are only available from with api version 3.1+

@FlorianVeaux FlorianVeaux requested a review from a team as a code owner July 4, 2019 15:57
@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #4044 into master will increase coverage by 15.68%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master    #4044       +/-   ##
===========================================
+ Coverage   79.45%   95.13%   +15.68%     
===========================================
  Files         152       19      -133     
  Lines        8089     5200     -2889     
  Branches      990      206      -784     
===========================================
- Hits         6427     4947     -1480     
+ Misses       1435      176     -1259     
+ Partials      227       77      -150

@ofek ofek changed the title Bugfix for events submission Fix event submission call Jul 5, 2019
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ofek ofek merged commit c817038 into master Jul 5, 2019
@ofek ofek deleted the florian/fix_cisco_bugs branch July 5, 2019 04:46
@FlorianVeaux
Copy link
Contributor Author

@DataDog DataDog deleted a comment from FlorianVeaux Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants