Add support for string types #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SNMP can return float values as string, either directly as a OctetString or via a Opaque value. Let's support those types of OIDs.
Codecov Report
@@ Coverage Diff @@
## master #4087 +/- ##
==========================================
+ Coverage 79.96% 87.98% +8.02%
==========================================
Files 161 7 -154
Lines 8389 666 -7723
Branches 1013 110 -903
==========================================
- Hits 6708 586 -6122
+ Misses 1447 51 -1396
+ Partials 234 29 -205 |
hithwen
requested changes
Jul 10, 2019
hithwen
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNMP can return float values as string, either directly as a OctetString
or via a Opaque value. Let's support those types of OIDs.