Use utcnow instead of now #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
1 similar comment
Codecov Report
|
Codecov Report
|
hithwen
reviewed
Jul 26, 2019
| @@ -34,7 +34,7 @@ def __init__(self, name, init_config, agentConfig, instances=None): | |||
|
|
|||
| def check(self, instance): | |||
| self.log.info("Starting Cisco Check") | |||
| start = datetime.datetime.now() | |||
| start = datetime.datetime.utcnow() | |||
There was a problem hiding this comment.
In this case is a bit irrelevant because it is just used to calculate a time delta
There was a problem hiding this comment.
Might prevent the edge case when we have a DST change on local machine between start and end, we might not have the right delta.
hithwen
approved these changes
Jul 26, 2019
ofek
added
changelog/no-changelog
changelog/Fixed
and removed
changelog/Fixed
changelog/no-changelog
labels
ofek
added
changelog/no-changelog
changelog/Fixed
and removed
changelog/no-changelog
changelog/Fixed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use
utcnowinstead ofnowto avoid possible DST and timezone issues.Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached