New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia/couchbase e2e #4328
Julia/couchbase e2e #4328
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment about the "extract_device" logic.
device = BUCKET_NAME | ||
else: | ||
tags.append('device:{}'.format(BUCKET_NAME)) | ||
device = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feel a bit hackish to make the test work for both integration and e2e.
This reverts commit a636ac8.
Adds couchbase e2e
Support for device check in e2e tests. Changes to base and dev have been also tested against apache e2e test