Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia/couchbase e2e #4328

Merged
merged 9 commits into from Aug 9, 2019
Merged

Julia/couchbase e2e #4328

merged 9 commits into from Aug 9, 2019

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Aug 8, 2019

Adds couchbase e2e
Support for device check in e2e tests. Changes to base and dev have been also tested against apache e2e test

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #4328 into master will decrease coverage by 7.1%.
The diff coverage is 84.9%.

Impacted file tree graph

Impacted Files Coverage Δ
datadog_checks_dev/datadog_checks/dev/_env.py 53.22% <ø> (ø) ⬆️
...g_checks_base/datadog_checks/base/stubs/similar.py 87.87% <100%> (+0.57%) ⬆️
couchbase/datadog_checks/couchbase/couchbase.py 69.06% <100%> (-0.67%) ⬇️
datadog_checks_base/tests/test_similar.py 100% <100%> (ø) ⬆️
...dog_checks_base/datadog_checks/base/checks/base.py 74.76% <100%> (+0.15%) ⬆️
...og_checks_base/datadog_checks/base/stubs/common.py 100% <100%> (ø) ⬆️
couchbase/tests/test_couchbase.py 88.46% <68.42%> (-11.54%) ⬇️
...hecks_base/datadog_checks/base/stubs/aggregator.py 67.08% <75%> (-0.85%) ⬇️
datadog_checks_base/tests/test_pdhbasecheck.py 32% <0%> (-68%) ⬇️
datadog_checks_base/tests/test_winpdh.py 32.55% <0%> (-65.12%) ⬇️
... and 675 more

Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment about the "extract_device" logic.

device = BUCKET_NAME
else:
tags.append('device:{}'.format(BUCKET_NAME))
device = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feel a bit hackish to make the test work for both integration and e2e.

@hithwen hithwen mentioned this pull request Aug 9, 2019
@hithwen hithwen merged commit a636ac8 into master Aug 9, 2019
@hithwen hithwen deleted the julia/couchbase-e2e branch August 9, 2019 12:52
AlexandreYang added a commit that referenced this pull request Aug 9, 2019
AlexandreYang added a commit that referenced this pull request Aug 9, 2019
AlexandreYang added a commit that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants