Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add druid logs #4561

Merged
merged 6 commits into from
Oct 17, 2019
Merged

Add druid logs #4561

merged 6 commits into from
Oct 17, 2019

Conversation

AlexandreYang
Copy link
Member

Add druid logs

@AlexandreYang AlexandreYang mentioned this pull request Sep 17, 2019
Closed
@AlexandreYang AlexandreYang marked this pull request as ready for review October 16, 2019 17:21
@AlexandreYang AlexandreYang requested review from a team as code owners October 16, 2019 17:21
@AlexandreYang AlexandreYang changed the title [HOLD] Add druid logs Add druid logs Oct 16, 2019
FlorianVeaux
FlorianVeaux previously approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Can we also get a review for @DataDog/baklava ?

ruthnaebeck
ruthnaebeck suggested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review.

Edit: Looks like the title was already fixed.

druid/README.md Outdated Show resolved Hide resolved
druid/README.md Outdated Show resolved Hide resolved
druid/datadog_checks/druid/data/conf.yaml.example Outdated Show resolved Hide resolved
druid/datadog_checks/druid/data/conf.yaml.example Outdated Show resolved Hide resolved
druid/datadog_checks/druid/data/conf.yaml.example Outdated Show resolved Hide resolved
@AlexandreYang @ruthnaebeck
Update druid/README.md
01dc9da 
Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
AlexandreYang and others added 4 commits October 17, 2019 10:11
@AlexandreYang @ruthnaebeck
Update druid/datadog_checks/druid/data/conf.yaml.example
834ef99 
Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
@AlexandreYang @ruthnaebeck
Update druid/README.md
0f709c9 
Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
@AlexandreYang @ruthnaebeck
Update druid/datadog_checks/druid/data/conf.yaml.example
5c11a8a 
Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
@AlexandreYang @ruthnaebeck
Update druid/datadog_checks/druid/data/conf.yaml.example
14ff157 
Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
ruthnaebeck
ruthnaebeck approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@AlexandreYang AlexandreYang merged commit 25ba819 into master Oct 17, 2019
@AlexandreYang AlexandreYang deleted the alex/druid/add_logs2 branch October 17, 2019 14:07
FlorianVeaux pushed a commit that referenced this pull request Oct 17, 2019
@AlexandreYang @FlorianVeaux
Add druid logs (#4561)
221173a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

Assignees
No one assigned
Labels
integration/druid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexandreYang @ruthnaebeck @FlorianVeaux