Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version metadata #4927

Merged
merged 4 commits into from
Nov 29, 2019
Merged

Add version metadata #4927

merged 4 commits into from
Nov 29, 2019

Conversation

gianpaulrachiele
Copy link
Contributor

What does this PR do?

Submits metadata to inventories which is already collected by the Zookeeper Integration
Add tests

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@gianpaulrachiele gianpaulrachiele requested a review from a team as a code owner October 30, 2019 16:41
@codecov
Copy link

codecov bot commented Oct 30, 2019

@AlexandreYang AlexandreYang changed the title add version metadata to zookeeper integration Add version metadata Nov 5, 2019
zk/tests/test_zk.py Outdated Show resolved Hide resolved
zk/datadog_checks/zk/zk.py Show resolved Hide resolved
aerospike/datadog_checks/aerospike/aerospike.py Outdated Show resolved Hide resolved
aerospike/datadog_checks/aerospike/aerospike.py Outdated Show resolved Hide resolved
aerospike/tests/test_aerospike.py Outdated Show resolved Hide resolved
zk/datadog_checks/zk/zk.py Outdated Show resolved Hide resolved
zk/tests/test_zk.py Outdated Show resolved Hide resolved
@gianpaulrachiele gianpaulrachiele force-pushed the gianpaulrachiele/zookeeper-inventories branch from 5c8f192 to 5df586b Compare November 11, 2019 15:58
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just few minor comments.

zk/tests/conftest.py Outdated Show resolved Hide resolved
zk/tests/conftest.py Outdated Show resolved Hide resolved
zk/datadog_checks/zk/zk.py Show resolved Hide resolved
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No review needed from docs

@ofek ofek merged commit 5f3ca81 into master Nov 29, 2019
@ofek ofek deleted the gianpaulrachiele/zookeeper-inventories branch November 29, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants