Add version metadata #4949
Add version metadata #4949
Conversation
AlexandreYang
changed the base branch from
master
to
alex/postfix_add_tests_for_postqueue_mode
AlexandreYang
changed the base branch from
alex/postfix_add_tests_for_postqueue_mode
to
master
Codecov Report
|
AlexandreYang
changed the base branch from
master
to
alex/postfix_add_tests_for_postqueue_mode
AlexandreYang
changed the base branch from
alex/postfix_add_tests_for_postqueue_mode
to
master
AlexandreYang
force-pushed
the
alex/postfix_add_version_metadata
branch
3 times, most recently
from
a7342e5
to
24c5eb9
Compare
AlexandreYang
force-pushed
the
alex/postfix_add_version_metadata
branch
from
24c5eb9
to
5fe8106
Compare
| 'datadog_checks.postfix.postfix.get_subprocess_output', | ||
| return_value=('mail_version = {}'.format(MOCK_VERSION), None, None), | ||
| ) | ||
| def test_collect_metadata(aggregator, datadog_agent): |
There was a problem hiding this comment.
How does integration/e2e works for postfix? Can we also run a similar test against a real container?
There was a problem hiding this comment.
There is currently no integration/e2e with actual postfix installed.
Let me check if I can add a integration/e2e for that.
There was a problem hiding this comment.
I added this comment # TODO: Migrate this test as e2e test when it's possible to retrieve the metadata from the Agent
I added support for e2e here #4948
So, we can test in e2e when we can retrieve metadata from the agent.
It seems not possible to implement easily the test as integration since you need postfix to be installed on the same machine.
AlexandreYang
force-pushed
the
alex/postfix_add_version_metadata
branch
from
5fe8106
to
f8cad01
Compare
No description provided.