Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pywin32 to 227 #5036

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Upgrade pywin32 to 227 #5036

merged 1 commit into from
Nov 18, 2019

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Nov 18, 2019 •
edited
Loading

In order to build the Agent with Python 3.8, we need a compatible pywin32.

What does this PR do?

Upgrade pywin32 to 227.

Motivation

In order to build the Agent with Python 3.8, we need a compatible pywin32.

Additional Notes

See mhammond/pywin32#1327 mentioning that support is in starting from 226.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@remeh
Upgrade pywin32 to 227.
bcbf51d 
In order to build the Agent with Python 3.8, we need a compatible
pywin32.
@remeh remeh requested review from a team as code owners November 18, 2019 13:15
@codecov
Copy link

codecov bot commented Nov 18, 2019 •
edited
Loading

Codecov Report

Merging #5036 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted Files Coverage Δ
postgres/tests/common.py
vertica/tests/metrics.py
rabbitmq/tests/test_rabbitmq.py
vertica/datadog_checks/vertica/views.py
riakcs/datadog_checks/riakcs/riakcs.py
nagios/datadog_checks/nagios/__about__.py
zk/tests/test_e2e.py
...service/datadog_checks/windows_service/__init__.py
postgres/datadog_checks/postgres/postgres.py
supervisord/tests/conftest.py
... and 255 more

@ofek ofek changed the title Upgrade pywin32 to 227. Upgrade pywin32 to 227 Nov 18, 2019
ogaca-dd
ogaca-dd approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@ogaca-dd ogaca-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remeh remeh merged commit e5921cc into master Nov 18, 2019
@remeh remeh deleted the remeh/pywin32-227 branch November 18, 2019 16:29
@remeh remeh mentioned this pull request Nov 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve approved these changes

@mfpierre mfpierre mfpierre approved these changes

@ofek ofek ofek approved these changes

@ogaca-dd ogaca-dd ogaca-dd approved these changes

Assignees
No one assigned
Labels
integration/active_directory integration/aspdotnet integration/datadog_checks_base integration/dotnetclr integration/exchange_server integration/iis integration/pdh_check integration/sqlserver integration/win32_event_log integration/windows_service integration/wmi_check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@remeh @therve @mfpierre @ofek @ogaca-dd