Use RequestsWrapper #5037
Merged
Use RequestsWrapper #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therve
commented
Nov 18, 2019
| self.appcenter = False | ||
| if sessions is None: | ||
| self.sessions = [] | ||
| self.appcenter = appcenter |
There was a problem hiding this comment.
This is a possible fix.
Codecov Report
|
ofek
reviewed
Nov 24, 2019
cisco_aci/tests/common.py
Outdated
| 3. Returns the corresponding file content | ||
| """ | ||
|
|
||
| fixture_dirs = ALL_FICTURE_DIR |
There was a problem hiding this comment.
nit: maybe we can fix the typo while we're here
ofek
reviewed
Nov 24, 2019
| @@ -5,6 +5,7 @@ envlist = | |||
| py{27,37} | |||
|
|
|||
| [testenv] | |||
| usedevelop = true | |||
ofek
previously approved these changes
Nov 24, 2019
therve
force-pushed
the
therve/cisco-wrapper
branch
from
cdf77ea
to
18865b8
Compare
ofek
approved these changes
Nov 25, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the request wrapper instead of sessions directly, and tries to
simplify the tests.