Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reattempt to resolve IP on failure #6012

Merged
merged 5 commits into from
Mar 11, 2020
Merged

Reattempt to resolve IP on failure #6012

merged 5 commits into from
Mar 11, 2020

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Mar 10, 2020

Reattempts to resolve IP on failure. This can happen when DSN changes.
To do so in a sensible way I've refactored the integration a bit, specially exception handling

@hithwen hithwen requested a review from a team as a code owner March 10, 2020 15:56
florimondmanca
florimondmanca suggested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

tcp_check/tests/test_tcp_check.py Outdated Show resolved Hide resolved
hithwen and others added 2 commits March 10, 2020 18:02
@hithwen @florimondmanca
Update tcp_check/tests/test_tcp_check.py
0eaa291 
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
@hithwen
Style fix
cbd24b0
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #6012 into master will decrease coverage by 2.22%.
The diff coverage is 82.6%.

Impacted Files Coverage Δ
tcp_check/datadog_checks/tcp_check/tcp_check.py 73.68% <80.55%> (+10.17%) ⬆️
tcp_check/tests/test_tcp_check.py 97.72% <90%> (-2.28%) ⬇️
...ts/tooling/configuration/consumers/test_example.py
...checks_dev/tests/plugin/test_environment_runner.py
oracle/tests/test_oracle.py
...r/datadog_checks/openstack_controller/__about__.py
twistlock/datadog_checks/twistlock/twistlock.py
linkerd/datadog_checks/linkerd/linkerd.py
...hecks/openstack_controller/openstack_controller.py
btrfs/tests/test_btrfs.py
... and 808 more

florimondmanca
florimondmanca approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hithwen hithwen merged commit a1b055b into master Mar 11, 2020
@hithwen hithwen deleted the julia/tcp-to-reaquire-connection-on-dns-change branch March 11, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
integration/tcp_check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hithwen @florimondmanca