Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logs sourcecategory #6121

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Remove logs sourcecategory #6121

merged 3 commits into from
Mar 24, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Mar 23, 2020 •
edited
Loading

What does this PR do?

Remove logs sourcecategory.

Motivation

sourcecategory is not used for the moment.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@AlexandreYang AlexandreYang marked this pull request as ready for review March 23, 2020 16:30
@AlexandreYang AlexandreYang requested review from anshumgargdd and a team as code owners March 23, 2020 16:30
@AlexandreYang
Copy link
Member Author

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@AlexandreYang
Copy link
Member Author

/azp PR All

@azure-pipelines
Copy link

Command 'PR' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@codecov
Copy link

codecov bot commented Mar 23, 2020 •
edited
Loading

Codecov Report

Merging #6121 into master will decrease coverage by 5.49%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...ts/tooling/configuration/consumers/test_example.py 100.00% <ø> (ø)
mysql/tests/conftest.py 92.30% <ø> (ø)
php_fpm/datadog_checks/php_fpm/__init__.py
..._controller/tests/test_nginx_ingress_controller.py
pgbouncer/tests/conftest.py
...heduler/datadog_checks/kube_scheduler/__about__.py
datadog_checks_base/tests/test_winpdh.py
datadog_checks_base/tests/test_constants.py
pgbouncer/tests/test_pgbouncer_unit.py
btrfs/tests/test_btrfs.py
... and 747 more

@azure-pipelines
Copy link

Command 'rjun' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@AlexandreYang
Copy link
Member Author

/azp run "PR All"

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

NBParis
NBParis previously approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@NBParis NBParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ofek
ofek previously approved these changes Mar 23, 2020
View reviewed changes
@AlexandreYang AlexandreYang dismissed stale reviews from ofek and NBParis via 4ef0224 March 23, 2020 17:09
@AlexandreYang AlexandreYang mentioned this pull request Mar 23, 2020
Closed
4 tasks
@AlexandreYang AlexandreYang merged commit 6040d5d into master Mar 24, 2020
@AlexandreYang AlexandreYang deleted the alex/unused_source_category branch March 24, 2020 09:02
@ChristineTChen ChristineTChen mentioned this pull request Mar 25, 2020
Merged
4 tasks
@FlorianVeaux FlorianVeaux mentioned this pull request Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0k0ms l0k0ms l0k0ms approved these changes

@ofek ofek ofek left review comments

@NBParis NBParis NBParis left review comments

@anshumgargdd anshumgargdd Awaiting requested review from anshumgargdd

Assignees
No one assigned
Labels
dev/tooling documentation integration/active_directory integration/activemq integration/airflow integration/ambari integration/apache integration/cassandra integration/ceph integration/clickhouse integration/consul integration/couch integration/couchbase integration/datadog_checks_dev integration/druid integration/elastic integration/envoy integration/flink integration/fluentd integration/gitlab integration/gunicorn integration/haproxy integration/hdfs_datanode integration/hdfs_namenode integration/hive integration/ibm_db2 integration/ibm_mq integration/ibm_was integration/iis integration/jboss_wildfly integration/kafka integration/kong integration/marathon integration/mcache integration/mongo integration/mysql integration/nginx integration/openldap integration/pgbouncer integration/postfix integration/postgres integration/presto integration/rabbitmq integration/redisdb integration/riak integration/scylla integration/squid integration/tenable integration/tomcat integration/varnish integration/vault integration/vertica integration/win32_event_log integration/zk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlexandreYang @l0k0ms @ofek @NBParis