Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config spec #6314

Merged
merged 8 commits into from
Apr 17, 2020
Merged

Add config spec #6314

merged 8 commits into from
Apr 17, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Apr 10, 2020

Description

Add Cisco ACI config spec

Note: Many auth_types have been commented since we don't support them. See

def login_for_url(self, aci_url):
if self.password:
session_wrapper = self.password_login(aci_url)
elif self.cert_key:
session_wrapper = self.setup_cert_login(aci_url)
else:
# Either a password or a cert should be present since we validated that in __init__
raise ConfigurationError('Expect either a password or a cert to be present')
return session_wrapper

@AlexandreYang AlexandreYang requested review from a team as code owners April 10, 2020 16:22
@AlexandreYang AlexandreYang changed the title Add Cisco ACI config spec [WIP] Add Cisco ACI config spec Apr 10, 2020
##
## This overrides the `timeout` setting in `init_config`.
#
# timeout: 10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timeout changed to 10:

#
# ssl_verify: true
# tls_private_key: <PRIVATE_KEY_PATH>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ssl_verify has been renamed to tls_verify

HTTP_CONFIG_REMAPPER = {'ssl_verify': {'name': 'tls_verify'}, 'pwd': {'name': 'password'}}

@AlexandreYang AlexandreYang changed the title [WIP] Add Cisco ACI config spec Add Cisco ACI config spec Apr 10, 2020
@AlexandreYang AlexandreYang changed the title Add Cisco ACI config spec Add config spec Apr 10, 2020
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ofek ofek merged commit a032ffc into master Apr 17, 2020
@ofek ofek deleted the alex/cisco_aci_config_spec branch April 17, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants