Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor check and support new Agent signature #6341

Merged
merged 7 commits into from
Apr 15, 2020

Conversation

ChristineTChen
Copy link
Contributor

Clean up constants and metrics in Istio check, refactor code

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #6341 into master will increase coverage by 5.10%.
The diff coverage is 98.13%.

Impacted Files Coverage Δ
istio/tests/conftest.py 85.54% <96.61%> (+27.20%) ⬆️
istio/datadog_checks/istio/constants.py 100.00% <100.00%> (ø)
istio/datadog_checks/istio/istio.py 96.47% <100.00%> (-0.24%) ⬇️
istio/datadog_checks/istio/metrics.py 100.00% <100.00%> (ø)
istio/tests/common.py 100.00% <100.00%> (ø)
istio/tests/test_check.py 100.00% <100.00%> (+1.98%) ⬆️
..._checks_base/datadog_checks/base/utils/tailfile.py
consul/datadog_checks/consul/consul.py
...tadog_checks/base/checks/kube_leader/base_check.py
prometheus/datadog_checks/prometheus/__about__.py
... and 834 more

istio/datadog_checks/istio/istio.py Outdated Show resolved Hide resolved
istio/datadog_checks/istio/istio.py Outdated Show resolved Hide resolved
istio/datadog_checks/istio/istio.py Show resolved Hide resolved
@ofek ofek changed the title Refactor Istio check and new signature Refactor check and support new Agent signature Apr 15, 2020
@ChristineTChen ChristineTChen merged commit 24c706f into master Apr 15, 2020
@ChristineTChen ChristineTChen deleted the cc/istio-refactor branch April 15, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants