Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to support different versions of istio #6360

Merged
merged 8 commits into from
Apr 17, 2020
Merged

Refactor to support different versions of istio #6360

merged 8 commits into from
Apr 17, 2020

Conversation

ChristineTChen
Copy link
Contributor

@ChristineTChen ChristineTChen commented Apr 15, 2020 •
edited
Loading

Support for istio 1.5 via new check that is independent from <1.5 versions. Adds new config option istiod_endpoint to monitor the istiod deployment. See PoC #6204

@ChristineTChen ChristineTChen requested review from a team as code owners April 15, 2020 23:49
@codecov
Copy link

codecov bot commented Apr 15, 2020 •
edited
Loading

Codecov Report

Merging #6360 into master will increase coverage by 4.31%.
The diff coverage is 93.54%.

Impacted Files Coverage Δ
istio/datadog_checks/istio/istio.py 72.72% <62.50%> (ø)
istio/datadog_checks/istio/legacy_1_4.py 96.47% <96.47%> (ø)
consul/tests/common.py
tomcat/tests/common.py
clickhouse/tests/test_clickhouse.py
envoy/tests/test_utils.py
datadog_checks_dev/tests/tooling/test_utils.py
proxysql/datadog_checks/proxysql/ssl_utils.py
network/datadog_checks/network/__init__.py
mapr/tests/test_unit.py
... and 842 more

ofek
ofek requested changes Apr 16, 2020
View reviewed changes
istio/datadog_checks/istio/istio.py Outdated Show resolved Hide resolved
@ChristineTChen @ofek
Update istio/datadog_checks/istio/istio.py
efe9366 
Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
ruthnaebeck
ruthnaebeck suggested changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

istio/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
istio/datadog_checks/istio/data/conf.yaml.example Outdated Show resolved Hide resolved
ChristineTChen and others added 2 commits April 16, 2020 14:46
@ChristineTChen @ruthnaebeck
Update istio/assets/configuration/spec.yaml
714c88d 
Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
@ChristineTChen @ruthnaebeck
Update istio/datadog_checks/istio/data/conf.yaml.example
02fb3e2 
Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
@ChristineTChen ChristineTChen mentioned this pull request Apr 16, 2020
Merged
@ChristineTChen ChristineTChen changed the title Support different versions of istio Refactor to support different versions of istio Apr 17, 2020
ruthnaebeck
ruthnaebeck approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@ChristineTChen ChristineTChen merged commit aad0d3f into master Apr 17, 2020
@ChristineTChen ChristineTChen deleted the cc/istio-ver branch April 17, 2020 16:59
@ChristineTChen ChristineTChen mentioned this pull request Apr 21, 2020
Merged
@ChristineTChen ChristineTChen changed the title Refactor to support different versions of istio Refactor to support different versions of istio Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes

Assignees
No one assigned
Labels
documentation integration/istio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristineTChen @ofek @ruthnaebeck