Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about warning concurrency #6967

Merged
merged 7 commits into from
Jun 26, 2020
Merged

Add note about warning concurrency #6967

merged 7 commits into from
Jun 26, 2020

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Add a note to tls_ignore_warning configuration for the user to expect spurious warnings even when this is set to true.

Motivation

Support case. Warnings are handled in a non thread-safe way (#5080), and while we decide the best approach here, we should make clear this race condition can happen.

Additional Notes

Modified the specs templates and the http_check. Once the note wording is approved I will add it to the other integrations.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment