Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pywin32 to 228 #6980

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Upgrade pywin32 to 228 #6980

merged 1 commit into from
Jun 25, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jun 25, 2020

Motivation

Need mhammond/pywin32#1524 for win32_event_log rewrite

@ofek ofek requested review from trishankatdatadog and a team as code owners June 25, 2020 19:37
@codecov
Copy link

codecov bot commented Jun 25, 2020 •
edited
Loading

Codecov Report

Merging #6980 into master will decrease coverage by 2.23%.
The diff coverage is n/a.

Impacted Files Coverage Δ
mapr/datadog_checks/mapr/__init__.py
directory/datadog_checks/directory/__about__.py
kube_proxy/datadog_checks/kube_proxy/__about__.py
tcp_check/tests/test_tcp_check.py
riak/tests/common.py
...s/kube_apiserver_metrics/kube_apiserver_metrics.py
directory/datadog_checks/directory/traverse.py
...checks_dev/datadog_checks/dev/tooling/constants.py
mesos_master/tests/utils.py
ambari/datadog_checks/ambari/__init__.py
... and 877 more

mgarabed
mgarabed approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@mgarabed mgarabed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - assuming CI passes, LGTM!

trishankatdatadog
trishankatdatadog approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofek ofek merged commit d484cd2 into master Jun 25, 2020
@ofek ofek deleted the ofek/u branch June 25, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgarabed mgarabed mgarabed approved these changes

@trishankatdatadog trishankatdatadog trishankatdatadog approved these changes

Assignees
No one assigned
Labels
dependencies integration/active_directory integration/aspdotnet integration/datadog_checks_base integration/dotnetclr integration/exchange_server integration/iis integration/pdh_check integration/sqlserver integration/win32_event_log integration/windows_service integration/wmi_check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ofek @mgarabed @trishankatdatadog