Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-838 Template wording #7038

Merged
merged 14 commits into from
Jul 21, 2020
Merged

DOCS-838 Template wording #7038

merged 14 commits into from
Jul 21, 2020

Conversation

ruthnaebeck
Copy link
Contributor

What does this PR do?

Update integration template wording

Motivation

#6151

Additional Notes

Replaces #6745

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #7038 into master will decrease coverage by 8.73%.
The diff coverage is n/a.

Impacted Files Coverage Δ
datadog_checks_dev/tests/test_docker.py 48.14% <0.00%> (-51.86%) ⬇️
datadog_checks_dev/tests/tooling/test_utils.py 73.40% <0.00%> (-26.60%) ⬇️
datadog_checks_dev/datadog_checks/dev/env.py 22.72% <0.00%> (-20.46%) ⬇️
datadog_checks_dev/datadog_checks/dev/warn.py 63.63% <0.00%> (-18.19%) ⬇️
...atadog_checks_dev/datadog_checks/dev/structures.py 68.85% <0.00%> (-18.04%) ⬇️
datadog_checks_dev/tests/test_conditions.py 82.25% <0.00%> (-17.75%) ⬇️
datadog_checks_dev/datadog_checks/dev/docker.py 24.81% <0.00%> (-17.30%) ⬇️
datadog_checks_dev/datadog_checks/dev/_env.py 54.79% <0.00%> (-9.59%) ⬇️
...atadog_checks_dev/datadog_checks/dev/subprocess.py 72.97% <0.00%> (-5.41%) ⬇️
...atadog_checks_dev/datadog_checks/dev/conditions.py 81.13% <0.00%> (-4.72%) ⬇️
... and 1080 more

sarina-dd
sarina-dd previously approved these changes Jul 16, 2020
@ChristineTChen
Copy link
Contributor

CI is failing because configs are not synced after updates

@ruthnaebeck
Copy link
Contributor Author

@ChristineTChen - At this point, I'm not sure what to do. If I run ddev validate config --sync it puts back all the "mistakes" from before.

Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChristineTChen ChristineTChen merged commit df3b815 into master Jul 21, 2020
@ChristineTChen ChristineTChen deleted the ruth/docs-838b branch July 21, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment