Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ntlm_domain example #7118

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Update ntlm_domain example #7118

merged 1 commit into from
Jul 14, 2020

Conversation

ian28223
Copy link
Contributor

@ian28223 ian28223 commented Jul 14, 2020 •
edited by AlexandreYang
Loading

What does this PR do?

Update ntlm_domain example syntax from frontslash to backslash

Motivation

Customer ran into this issue by following the example syntax

Source: https://docs.microsoft.com/en-us/windows/win32/secauthn/user-name-formats#down-level-logon-name

@ian28223 ian28223 requested review from a team as code owners July 14, 2020 03:20
@codecov
Copy link

codecov bot commented Jul 14, 2020 •
edited
Loading

Codecov Report

Merging #7118 into master will decrease coverage by 6.24%.
The diff coverage is n/a.

Impacted Files Coverage Δ
tcp_check/datadog_checks/tcp_check/__about__.py
gitlab/tests/test_integration_e2e.py
istio/tests/common.py
hive/tests/common.py
rethinkdb/tests/unit/test_config.py
lighttpd/datadog_checks/lighttpd/__about__.py
..._namenode/datadog_checks/hdfs_namenode/__init__.py
activemq/tests/conftest.py
...nkdb/datadog_checks/rethinkdb/document_db/utils.py
gunicorn/tests/common.py
... and 730 more

@hithwen hithwen merged commit 5d992e4 into master Jul 14, 2020
@hithwen hithwen deleted the ian.bucad/doc_ntlm_domain branch July 14, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
dev/tooling documentation integration/activemq_xml integration/airflow integration/ambari integration/apache integration/consul integration/couch integration/couchbase integration/datadog_checks_dev integration/druid integration/ecs_fargate integration/elastic integration/envoy integration/etcd integration/fluentd integration/gitlab_runner integration/gitlab integration/go_expvar integration/haproxy integration/hdfs_datanode integration/hdfs_namenode integration/http_check integration/istio integration/kong integration/kube_apiserver_metrics integration/kyototycoon integration/lighttpd integration/mapreduce integration/marathon integration/mesos_master integration/mesos_slave integration/nginx_ingress_controller integration/nginx integration/openmetrics integration/openstack_controller integration/php_fpm integration/powerdns_recursor integration/rabbitmq integration/spark integration/squid integration/twistlock integration/vault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ian28223 @hithwen