Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log integration #7616

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Add log integration #7616

merged 3 commits into from
Sep 29, 2020

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Add log integration to gearmand

Motivation

More logs

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested review from a team as code owners September 17, 2020 15:29
@codecov
Copy link

codecov bot commented Sep 17, 2020 •
edited
Loading

Codecov Report

Merging #7616 into master will decrease coverage by 12.09%.
The diff coverage is n/a.

Impacted Files Coverage Δ
prometheus/datadog_checks/prometheus/__about__.py
eks_fargate/datadog_checks/eks_fargate/__init__.py
kubelet/datadog_checks/kubelet/cadvisor.py
nfsstat/datadog_checks/nfsstat/__about__.py
go_expvar/datadog_checks/go_expvar/__about__.py
crio/tests/test_crio.py
openldap/tests/test_check.py
disk/datadog_checks/disk/__init__.py
redisdb/datadog_checks/redisdb/redisdb.py
kube_proxy/datadog_checks/kube_proxy/kube_proxy.py
... and 776 more

sarina-dd
sarina-dd previously approved these changes Sep 17, 2020
View reviewed changes
FlorianVeaux
FlorianVeaux reviewed Sep 18, 2020
View reviewed changes
gearmand/README.md Outdated Show resolved Hide resolved
FlorianVeaux
FlorianVeaux requested changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@FlorianVeaux FlorianVeaux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See prior comment

@coignetp @FlorianVeaux
Update gearmand/README.md
3f83ede 
Co-authored-by: Florian Veaux <florian.veaux@datadoghq.com>
@coignetp coignetp merged commit dabf4b7 into master Sep 29, 2020
@coignetp coignetp deleted the paul/gearman-logs branch September 29, 2020 08:39
github-actions bot pushed a commit that referenced this pull request Sep 29, 2020
@coignetp
Add log integration (#7616)
6d4cc55 
* Add log documentation

* Update gearmand/README.md

Co-authored-by: Florian Veaux <florian.veaux@datadoghq.com>

Co-authored-by: Florian Veaux <florian.veaux@datadoghq.com> dabf4b7
@ofek ofek mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

@sarina-dd sarina-dd sarina-dd left review comments

Assignees
No one assigned
Labels
documentation integration/gearmand logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coignetp @FlorianVeaux @sarina-dd