-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OAuth authentication option and use new connection on check run #7703
Conversation
Codecov Report
|
def test_default_authentication(instance): | ||
# Test default auth | ||
check = SnowflakeCheck(CHECK_NAME, {}, [instance]) | ||
assert check.config.authenticator == 'snowflake' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) I would favour testing that sf.connect()
is receiving the correct authenticator
param using a mock.assert_called_with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
What does this PR do?
This PR adds OAuth as per beta user feedback.
This PR also fixes connection issue because the snowflake python connector's connection must be explicitly closed. see
snowflakedb/snowflake-connector-python/issues/42
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached