[doc] Add encoding in log config sample #7708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhan289
reviewed
Oct 2, 2020
| @@ -120,6 +120,7 @@ instances: | |||
| ## Set channel_path if type is windows_event. | |||
| ## source - required - Attribute that defines which Integration sent the logs. | |||
| ## service - optional - The name of the service that generates the log. | |||
| ## encoding - optional - Set the file encoding, SQL Server error log uses utf-16-le. | |||
There was a problem hiding this comment.
Instead of directly changing the conf.yaml.example, you could modify the spec.yaml file (sqlserver/assets/configuration/spec.yaml) since we run a script to automatically generate the conf.yaml.example now. There is a template for logs (datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/logs.yaml), which you can just use and override to include the additional encoding information.
prognant
force-pushed
the
prognant/sqlserver-utf16-encoding
branch
from
3f4c4e6
to
8ac88fb
Compare
prognant
force-pushed
the
prognant/sqlserver-utf16-encoding
branch
from
8ac88fb
to
2f4185d
Compare
ghost
added
integration/active_directory
integration/activemq
integration/airflow
integration/ambari
integration/apache
integration/cassandra
integration/ceph
integration/clickhouse
integration/consul
integration/confluent_platform
integration/couchbase
integration/couch
integration/druid
integration/elastic
integration/envoy
labels
ghost
added
integration/mapreduce
integration/marathon
integration/marklogic
integration/mongo
integration/mysql
integration/nginx
integration/pgbouncer
integration/postgres
integration/rabbitmq
integration/redisdb
integration/rethinkdb
integration/riak
integration/sidekiq
integration/solr
integration/spark
integration/sqlserver
integration/squid
integration/supervisord
integration/tenable
integration/tomcat
integration/varnish
integration/vault
integration/vertica
integration/yarn
integration/zk
labels
hithwen
approved these changes
Oct 6, 2020
kayayarai
reviewed
Oct 6, 2020
| @@ -94,6 +94,8 @@ instances: | |||
| ## Set path if type is file. | |||
| ## Set channel_path if type is windows_event. | |||
| ## source - required - Attribute that defines which Integration sent the logs. | |||
| ## encoding - optional - For file specifies the file encoding, default is utf-8, other | |||
There was a problem hiding this comment.
Specifies the encoding for the file. The default is utf-8. Other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the encoding option for log configuration templates.
As per https://docs.microsoft.com/en-us/sql/linux/sql-server-linux-troubleshooting-guide?view=sql-server-ver15#access-the-log-files the log are encoded using utf-16-le by default so the default config for this integration has been updated accordingly.
Motivation
Windows support.
Additional Notes
N/A
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached