Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker_daemon] add custom tags to all service checks #782

Merged

Conversation

antoinepouille
Copy link
Contributor

@antoinepouille antoinepouille commented Sep 29, 2017

What does this PR do?

It adds the custom tags specified in the docker_daemon.yaml into the integration

Motivation

Customer request: the customer wants to distinguish service checks between his different environments

Testing Guidelines

Local tests successful

Versioning

  • Bumped the version check in manifest.json
  • Updated CHANGELOG.md. Please use Unreleased as the date in the title
    for the new section.

@antoinepouille antoinepouille force-pushed the antoine/docker_daemon-add-tags-to-service-checks branch from 7446186 to b380e29 Compare September 29, 2017 15:54
@antoinepouille antoinepouille added this to the 5.18 milestone Sep 29, 2017
@truthbk truthbk modified the milestones: 5.18, 5.19 Oct 4, 2017
@antoinepouille antoinepouille force-pushed the antoine/docker_daemon-add-tags-to-service-checks branch 7 times, most recently from 1b580c0 to 184b2a9 Compare October 13, 2017 17:27
@antoinepouille antoinepouille force-pushed the antoine/docker_daemon-add-tags-to-service-checks branch from 184b2a9 to b5f1598 Compare October 16, 2017 13:47
Copy link
Contributor

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's 🚢 when Travis is green!

@antoinepouille antoinepouille merged commit 52cc3b0 into master Oct 16, 2017
@antoinepouille antoinepouille deleted the antoine/docker_daemon-add-tags-to-service-checks branch October 16, 2017 14:41
@olivielpeau olivielpeau modified the milestones: 5.19, 5.20 Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants