Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TUF, in-toto and securesystemslib #7844

Merged
merged 5 commits into from Oct 28, 2020
Merged

Update TUF, in-toto and securesystemslib #7844

merged 5 commits into from Oct 28, 2020

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Oct 23, 2020

@hithwen hithwen changed the title Update TUF Update TUF and in-toto Oct 23, 2020
florimondmanca
florimondmanca previously approved these changes Oct 23, 2020
View reviewed changes
@florimondmanca florimondmanca dismissed their stale review October 23, 2020 12:57

Tests are broken

florimondmanca
florimondmanca previously requested changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, but most likely because securesystemslib needs updating too:

tuf 0.14.0 requires securesystemslib>=0.16.0, but you'll have securesystemslib 0.14.2 which is incompatible.

https://dev.azure.com/datadoghq/integrations-core/_build/results?buildId=28809&view=logs&j=910f82a4-622d-5ace-f877-8b75c045486c&t=5d9c3c47-ba30-555e-64b3-3b7ff1f894dc&l=357

So:

securesystemslib[crypto,pynacl]==0.17.0

(Like we did in the companion PR)

trishankatdatadog
trishankatdatadog reviewed Oct 23, 2020
View reviewed changes
Copy link
Member

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

securesystemslib should also be updated to 0.17.0...

@trishankatdatadog
Copy link
Member

Also, would you mind holding off on these PRs for a bit? securesystemslib and in-toto should be updated in the next week or so...

@hithwen @trishankatdatadog
Apply suggestions from code review
16ed42a 
Co-authored-by: Trishank Karthik Kuppusamy <trishank.kuppusamy@datadoghq.com>
@trishankatdatadog
Copy link
Member

Also, would you mind holding off on these PRs for a bit? securesystemslib and in-toto should be updated in the next week or so...

@lukpueh any news on when we can expect the 1.0.0 in-toto release, please? 🙂

@ofek
Copy link
Contributor

ofek commented Oct 28, 2020

We freeze on Friday night for one week btw

@trishankatdatadog
Copy link
Member

We freeze on Friday night for one week btw

Ok, then let's go with what we got. Could we update securesystemslib to 0.17.0 in both files, please?

@hithwen hithwen changed the title Update TUF and in-toto Update TUF, in-toto and securesystemslib Oct 28, 2020
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #7844 into master will decrease coverage by 9.09%.
The diff coverage is n/a.

Impacted Files Coverage Δ
mesos_master/tests/common.py
mapr/datadog_checks/mapr/utils.py
...nkdb/datadog_checks/rethinkdb/document_db/utils.py
kubelet/datadog_checks/kubelet/cadvisor.py
..._iot_edge/datadog_checks/azure_iot_edge/metrics.py
...orm/datadog_checks/confluent_platform/__about__.py
network/tests/common.py
...enstack_controller/tests/test_openstack_sdk_api.py
kubelet/datadog_checks/kubelet/kubelet.py
envoy/datadog_checks/envoy/parser.py
... and 804 more

@lukpueh
Copy link

lukpueh commented Oct 28, 2020

@lukpueh any news on when we can expect the 1.0.0 in-toto release, please? 🙂

There's not much missing. in-toto 1.0.0 blocks on securesystemslib 0.18.0, which blocks on secure-systems-lab/securesystemslib#273, where I got some conflicting reviews (see secure-systems-lab/securesystemslib#288 (comment)). I hope to get some green lights later today, so that I can merge and cut sslib 0.18.0 and in-toto 1.0.0 releases tomorrow.

The good news is, TUF only needs some docs updates to adopt said sslib changes, which I have already prepared: theupdateframework/python-tuf#1191

@trishankatdatadog
Copy link
Member

The good news is, TUF only needs some docs updates to adopt said sslib changes, which I have already prepared: theupdateframework/tuf#1191

Thanks, Lukas! We will go ahead with this PR, and make another one tomorrow if there are new releases.

@hithwen hithwen merged commit 8fc0ef8 into master Oct 28, 2020
@hithwen hithwen deleted the julia/AI-1160-update-tuf branch October 28, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishankatdatadog trishankatdatadog trishankatdatadog approved these changes

@florimondmanca florimondmanca Awaiting requested review from florimondmanca

Assignees
No one assigned
Labels
dependencies integration/datadog_checks_base integration/datadog_checks_downloader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hithwen @trishankatdatadog @ofek @lukpueh @florimondmanca