Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workaround for issue in platform.platform() on python 3.8 or later #7932

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Add workaround for issue in platform.platform() on python 3.8 or later #7932

merged 2 commits into from
Nov 6, 2020

Conversation

kurochan
Copy link
Contributor

@kurochan kurochan commented Nov 4, 2020 •
edited
Loading

What does this PR do?

Fix #7931

Motivation

I implemented a workaround to run snowflake integration properly.

Additional Notes

#7931

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@kurochan kurochan requested a review from a team as a code owner November 4, 2020 12:52
@ChristineTChen ChristineTChen changed the title datadog-snowflake: workaround for issue in platform.platform() on python 3.8 or later Add workaround for issue in platform.platform() on python 3.8 or later Nov 5, 2020
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #7932 into master will increase coverage by 6.25%.
The diff coverage is 33.33%.

Impacted Files Coverage Δ
snowflake/datadog_checks/snowflake/__init__.py 66.66% <33.33%> (ø)
openstack_controller/tests/conftest.py
...s_base/tests/stubs/test_aggregator_no_duplicate.py
ecs_fargate/tests/test_unit.py
pgbouncer/datadog_checks/pgbouncer/metrics.py
activemq/tests/conftest.py
powerdns_recursor/tests/conftest.py
powerdns_recursor/tests/test_unit.py
envoy/datadog_checks/envoy/utils.py
disk/tests/test_check.py
... and 896 more

ChristineTChen
ChristineTChen approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested fix on Linux, confirmed workaround. Thanks @kurochan, this fix will be available in the Agent 7.24 release.

@hithwen hithwen merged commit 1c5afe2 into DataDog:master Nov 6, 2020
ofek pushed a commit that referenced this pull request Nov 6, 2020
@kurochan @ChristineTChen @ofek
Add workaround for issue in platform.platform() on python 3.8 or later (
8d727f0 
#7932)

* Fix #7931 datadog-snowflake: workaround for issue in platform.platform() on python 3.8 or later

* Update snowflake/datadog_checks/snowflake/__init__.py

Co-authored-by: Christine Chen <ChristineTChen@users.noreply.github.com>
@ofek ofek mentioned this pull request Sep 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen approved these changes

Assignees
No one assigned
Labels
integration/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datadog-snowflake: got error "Unable to load the check: unable to load any check from config 'snowflake'"
3 participants
@kurochan @ChristineTChen @hithwen