Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make role configuration step more explicit #8092

Merged
merged 15 commits into from
Dec 4, 2020
Merged

Conversation

ChristineTChen
Copy link
Contributor

@ChristineTChen ChristineTChen commented Nov 25, 2020

What does this PR do?

This PR emphasizes the creation of custom role to monitor Snowflake with sql example.

  • make role config option required because default ACCOUNTADMIN is removed.
  • encourages users to use better security practices according to Snowflake
  • Add example script for creating new user/role or just assigning permissions to sysadmin role
  • clarify debug log for proxy

Motivation

Make note more obvious in configuration step.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this is a better approach. Nice one!

@ChristineTChen ChristineTChen merged commit 2be518f into master Dec 4, 2020
@ChristineTChen ChristineTChen deleted the cc/snowflake-note branch December 4, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants